lkml.org 
[lkml]   [2023]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: sched/core] time/tick-broadcast: Remove RCU_NONIDLE() usage
    The following commit has been merged into the sched/core branch of tip:

    Commit-ID: e3ee5e66f78e9950b9ada276700abd95e9b144d7
    Gitweb: https://git.kernel.org/tip/e3ee5e66f78e9950b9ada276700abd95e9b144d7
    Author: Peter Zijlstra <peterz@infradead.org>
    AuthorDate: Thu, 12 Jan 2023 20:43:40 +01:00
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitterDate: Fri, 13 Jan 2023 11:48:16 +01:00

    time/tick-broadcast: Remove RCU_NONIDLE() usage

    No callers left that have already disabled RCU.

    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Tested-by: Tony Lindgren <tony@atomide.com>
    Tested-by: Ulf Hansson <ulf.hansson@linaro.org>
    Acked-by: Mark Rutland <mark.rutland@arm.com>
    Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Acked-by: Frederic Weisbecker <frederic@kernel.org>
    Link: https://lore.kernel.org/r/20230112195540.927904612@infradead.org
    ---
    kernel/time/tick-broadcast-hrtimer.c | 29 +++++++++++----------------
    1 file changed, 12 insertions(+), 17 deletions(-)

    diff --git a/kernel/time/tick-broadcast-hrtimer.c b/kernel/time/tick-broadcast-hrtimer.c
    index 797eb93..e28f921 100644
    --- a/kernel/time/tick-broadcast-hrtimer.c
    +++ b/kernel/time/tick-broadcast-hrtimer.c
    @@ -56,25 +56,20 @@ static int bc_set_next(ktime_t expires, struct clock_event_device *bc)
    * hrtimer callback function is currently running, then
    * hrtimer_start() cannot move it and the timer stays on the CPU on
    * which it is assigned at the moment.
    + */
    + hrtimer_start(&bctimer, expires, HRTIMER_MODE_ABS_PINNED_HARD);
    + /*
    + * The core tick broadcast mode expects bc->bound_on to be set
    + * correctly to prevent a CPU which has the broadcast hrtimer
    + * armed from going deep idle.
    *
    - * As this can be called from idle code, the hrtimer_start()
    - * invocation has to be wrapped with RCU_NONIDLE() as
    - * hrtimer_start() can call into tracing.
    + * As tick_broadcast_lock is held, nothing can change the cpu
    + * base which was just established in hrtimer_start() above. So
    + * the below access is safe even without holding the hrtimer
    + * base lock.
    */
    - RCU_NONIDLE( {
    - hrtimer_start(&bctimer, expires, HRTIMER_MODE_ABS_PINNED_HARD);
    - /*
    - * The core tick broadcast mode expects bc->bound_on to be set
    - * correctly to prevent a CPU which has the broadcast hrtimer
    - * armed from going deep idle.
    - *
    - * As tick_broadcast_lock is held, nothing can change the cpu
    - * base which was just established in hrtimer_start() above. So
    - * the below access is safe even without holding the hrtimer
    - * base lock.
    - */
    - bc->bound_on = bctimer.base->cpu_base->cpu;
    - } );
    + bc->bound_on = bctimer.base->cpu_base->cpu;
    +
    return 0;
    }

    \
     
     \ /
      Last update: 2023-03-26 23:39    [W:2.985 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site