lkml.org 
[lkml]   [2023]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5/6] kbuild: rust_is_available: fix confusion when a version appears in the path
    On Thu, Jan 12, 2023 at 6:32 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
    >
    > +set -- ${bindgen_libclang_output#**clang version}
    > +bindgen_libclang_cversion=$(get_canonical_version $1)
    > bindgen_libclang_min_version=$($min_tool_version llvm)
    > -bindgen_libclang_cversion=$(get_canonical_version $bindgen_libclang_version)

    Nice trick :) To be honest, I am not really fond of `set`, and in this
    case it means the command is not symmetric (we remove the prefix using
    parameter expansion, and the suffix via positional argument
    selection), but if you prefer it that way, I think it would be fine.

    However, why the double asterisk? One already matches any string,
    including spaces, no?

    Cheers,
    Miguel

    \
     
     \ /
      Last update: 2023-03-26 23:41    [W:8.970 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site