lkml.org 
[lkml]   [2023]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v6 3/6] phy: qcom-qmp: Add SM6125 UFS PHY support
    On Sun, 8 Jan 2023 at 21:54, Lux Aliaga <they@mint.lgbt> wrote:
    >
    > The SM6125 UFS PHY is compatible with the one from SM6115. Add a
    > compatible for it and modify the config from SM6115 to make them
    > compatible with the SC8280XP binding
    >
    > Signed-off-by: Lux Aliaga <they@mint.lgbt>
    > Reviewed-by: Martin Botka <martin.botka@somainline.org>
    > ---
    > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
    > index 318eea35b972..f33c84578940 100644
    > --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
    > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
    > @@ -693,6 +693,8 @@ static const struct qmp_phy_cfg sdm845_ufsphy_cfg = {
    > static const struct qmp_phy_cfg sm6115_ufsphy_cfg = {
    > .lanes = 1,
    >
    > + .offsets = &qmp_ufs_offsets_v5,

    Please don't randomly reuse generation-specific structures. This
    structure is clearly related to v5, while the PHY is from the v2
    generation.

    > +
    > .serdes_tbl = sm6115_ufsphy_serdes_tbl,
    > .serdes_tbl_num = ARRAY_SIZE(sm6115_ufsphy_serdes_tbl),
    > .tx_tbl = sm6115_ufsphy_tx_tbl,
    > @@ -1172,6 +1174,9 @@ static const struct of_device_id qmp_ufs_of_match_table[] = {
    > }, {
    > .compatible = "qcom,sm6115-qmp-ufs-phy",
    > .data = &sm6115_ufsphy_cfg,
    > + }, {
    > + .compatible = "qcom,sm6125-qmp-ufs-phy",
    > + .data = &sm6115_ufsphy_cfg,
    > }, {
    > .compatible = "qcom,sm6350-qmp-ufs-phy",
    > .data = &sdm845_ufsphy_cfg,
    > --
    > 2.39.0
    >


    --
    With best wishes
    Dmitry

    \
     
     \ /
      Last update: 2023-03-26 23:41    [W:2.381 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site