Messages in this thread | | | Date | Thu, 12 Jan 2023 18:22:25 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] gpiolib: of: Move enum of_gpio_flags to its only user |
| |
On Thu, Jan 12, 2023 at 04:51:40PM +0200, Andy Shevchenko wrote: > GPIO library for OF is the only user for enum of_gpio_flags. > Move it there.
...
> +/* > + * This is Linux-specific flags. By default controllers' and Linux' mapping > + * match, but GPIO controllers are free to translate their own flags to > + * Linux-specific in their .xlate callback. Though, 1:1 mapping is recommended. > + */
Now that I re-read the comment, I think this can be postponed until we get a consensus that no new driver is ever should do non 1:1 mapping.
If that consensus achieved, we may drop this enum altogether and replace it with the generic flags..
-- With Best Regards, Andy Shevchenko
| |