Messages in this thread | | | Date | Thu, 12 Jan 2023 08:47:08 -0600 | Subject | Re: [PATCH 14/19] soundwire: amd: add runtime pm ops for AMD master driver | From | Pierre-Louis Bossart <> |
| |
>>> +static int __maybe_unused amd_suspend_runtime(struct device *dev) >>> +{ >>> + struct amd_sdwc_ctrl *ctrl = dev_get_drvdata(dev); >>> + struct sdw_bus *bus = &ctrl->bus; >>> + int ret; >>> + >>> + if (bus->prop.hw_disabled || !ctrl->startup_done) { >> do you have a case where the startup is not done? This was an >> Intel-specific thing. > We have included startup_done flag in probe_work to check whether Manager > has started. In case if manager init sequence fails, then there is no need > to apply any PM ops.
Not following, sorry.
We introduced the .startup callback for intel because of a power dependency where we could not access and initialize the registers at the .probe time for the master driver.
Do you have a similar dependency, and if not why not remove this flag?
| |