lkml.org 
[lkml]   [2023]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 14/19] soundwire: amd: add runtime pm ops for AMD master driver
From


>>> +static int __maybe_unused amd_suspend_runtime(struct device *dev)
>>> +{
>>> + struct amd_sdwc_ctrl *ctrl = dev_get_drvdata(dev);
>>> + struct sdw_bus *bus = &ctrl->bus;
>>> + int ret;
>>> +
>>> + if (bus->prop.hw_disabled || !ctrl->startup_done) {
>> do you have a case where the startup is not done? This was an
>> Intel-specific thing.
> We have included startup_done flag in probe_work to check whether Manager
> has started. In case if manager init sequence fails, then there is no need
> to apply any PM ops.

Not following, sorry.

We introduced the .startup callback for intel because of a power
dependency where we could not access and initialize the registers at the
.probe time for the master driver.

Do you have a similar dependency, and if not why not remove this flag?


\
 
 \ /
  Last update: 2023-03-26 23:37    [W:0.059 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site