lkml.org 
[lkml]   [2023]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] PCI: Add translated request only opt-in for pci_enable_pasid()
From
On 2023/1/12 20:38, Jason Gunthorpe wrote:
> On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote:
>
>> -int pci_enable_pasid(struct pci_dev *pdev, int features);
>> +int pci_enable_pasid(struct pci_dev *pdev, int features, bool
>> transled_only);
>
> Please use a named flag so we can grep for it..

Sure. What do you think of this naming?

+ * @flags: device-specific flags
+ * - PCI_PASID_TRANSLED_REQ_ONLY: The PCI device only issues PASID
+ * memory requests of translated type.

> Discuss in the commit message that this is a temporary step and that
> pci_enable_pasid() needs to be moved to the drivers

I will add below in commit message:

At present, it is a common practice to enable/disable PCI PASID in the
iommu drivers. Considering that the device driver knows more about the
specific device, we will follow up by moving pci_enable_pasid() into
the specific device drivers.

--
Best regards,
baolu

\
 
 \ /
  Last update: 2023-03-26 23:37    [W:0.175 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site