lkml.org 
[lkml]   [2023]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 3/5] m68k/mm/motorola: specify pmd_page() type
From
On 12/26/22 09:44, Lorenzo Stoakes wrote:
> Failing to specify a specific type here breaks anything that relies on the type
> being explicitly known, such as page_folio().
>
> Make explicit the type of null pointer returned here.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
> arch/m68k/include/asm/motorola_pgtable.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/include/asm/motorola_pgtable.h b/arch/m68k/include/asm/motorola_pgtable.h
> index 7ac3d64c6b33..562b54e09850 100644
> --- a/arch/m68k/include/asm/motorola_pgtable.h
> +++ b/arch/m68k/include/asm/motorola_pgtable.h
> @@ -124,7 +124,7 @@ static inline void pud_set(pud_t *pudp, pmd_t *pmdp)
> * expects pmd_page() to exists, only to then DCE it all. Provide a dummy to
> * make the compiler happy.
> */
> -#define pmd_page(pmd) NULL
> +#define pmd_page(pmd) ((struct page *)NULL)
>
>
> #define pud_none(pud) (!pud_val(pud))

\
 
 \ /
  Last update: 2023-03-26 23:37    [W:5.265 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site