Messages in this thread | | | Date | Thu, 12 Jan 2023 15:59:37 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH v5] crypto: ccp: Sanitize sev_platform_init() error messages |
| |
On Tue, 10 Jan 2023, Jarkko Sakkinen wrote:
> The following functions end up calling sev_platform_init() or > __sev_platform_init_locked(): > > * sev_guest_init() > * sev_ioctl_do_pek_csr > * sev_ioctl_do_pdh_export() > * sev_ioctl_do_pek_import() > * sev_ioctl_do_pek_pdh_gen() > * sev_pci_init() > > However, only sev_pci_init() prints out the failed command error code, and > even there, the error message does not specify which SEV command failed. > > Address this by printing out the SEV command errors inside > __sev_platform_init_locked(), and differentiate between DF_FLUSH, INIT and > INIT_EX commands. As a side-effect, @error can be removed from the > parameter list. > > This extra information is particularly useful if firmware loading and/or > initialization is going to be made more robust, e.g. by allowing firmware > loading to be postponed. > > Signed-off-by: Jarkko Sakkinen <jarkko@profian.com>
Acked-by: David Rientjes <rientjes@google.com>
| |