Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Colin Foster <> | Subject | [PATCH v7 net-next 06/10] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml | Date | Thu, 12 Jan 2023 07:56:09 -1000 |
| |
The dsa.yaml binding contains duplicated bindings for address and size cells, as well as the reference to dsa-port.yaml. Instead of duplicating this information, remove the reference to dsa-port.yaml and include the full reference to dsa.yaml.
Signed-off-by: Colin Foster <colin.foster@in-advantage.com> Suggested-by: Vladimir Oltean <olteanv@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Rob Herring <robh@kernel.org> ---
v5 -> v7 * No change
v4 -> v5 * Add Rob Reviewed
v3 -> v4 * Add Reviewed tag * Remove unnecessary blank line deletion
v2 -> v3 * Remove #address-cells and #size-cells from v2. The examples were incorrect and fixed elsewhere. * Remove erroneous unevaluatedProperties: true under Ethernet Port. * Add back ref: dsa-port.yaml#.
v1 -> v2 * Add #address-cells and #size-cells to the switch layer. They aren't part of dsa.yaml. * Add unevaluatedProperties: true to the ethernet-port layer so it can correctly read properties from dsa.yaml.
--- Documentation/devicetree/bindings/net/dsa/qca8k.yaml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml index 6fc9bc985726..389892592aac 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml @@ -66,15 +66,11 @@ properties: With the legacy mapping the reg corresponding to the internal mdio is the switch reg with an offset of -1. +$ref: "dsa.yaml#" + patternProperties: "^(ethernet-)?ports$": type: object - properties: - '#address-cells': - const: 1 - '#size-cells': - const: 0 - patternProperties: "^(ethernet-)?port@[0-6]$": type: object @@ -116,7 +112,7 @@ required: - compatible - reg -additionalProperties: true +unevaluatedProperties: false examples: - | -- 2.25.1
| ![\](/images/icornerr.gif) |