Messages in this thread | | | Date | Wed, 11 Jan 2023 16:04:55 +0300 | From | Serge Semin <> | Subject | Re: [PATCH] dmaengine: dw-edma: remove redundant config PCI dependency for some Synopsys DesignWare eDMA driver configs |
| |
On Wed, Jan 11, 2023 at 01:16:37PM +0100, Lukas Bulwahn wrote: > While reviewing dependencies in some Kconfig files, I noticed the redundant > dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always, > since its introduction, been dependent on the config PCI. So, it is > sufficient to just depend on PCI_MSI, and know that the dependency on PCI > is implicitly implied. > > Reduce the dependencies of configs DW_EDMA and DW_EDMA_PCIE. > No functional change and effective change of Kconfig dependendencies.
Indeed. Thanks. Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Serge(y)
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > drivers/dma/dw-edma/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/dw-edma/Kconfig b/drivers/dma/dw-edma/Kconfig > index 7ff17b2db6a1..0408e515b2f3 100644 > --- a/drivers/dma/dw-edma/Kconfig > +++ b/drivers/dma/dw-edma/Kconfig > @@ -2,7 +2,7 @@ > > config DW_EDMA > tristate "Synopsys DesignWare eDMA controller driver" > - depends on PCI && PCI_MSI > + depends on PCI_MSI > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > help > @@ -11,7 +11,7 @@ config DW_EDMA > > config DW_EDMA_PCIE > tristate "Synopsys DesignWare eDMA PCIe driver" > - depends on PCI && PCI_MSI > + depends on PCI_MSI > select DW_EDMA > help > Provides a glue-logic between the Synopsys DesignWare > -- > 2.17.1 >
| |