lkml.org 
[lkml]   [2023]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] debugfs: allow to use regmap for print regs
Hi Greg,

> > void debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs,
> > -             int nregs, void __iomem *base, char *prefix)
> > +             int nregs, void __iomem *base, struct regmap *regmap,
> > +             char *prefix)
>
> This is confusing, please just provide a new function for regmap instead
> of trying to overload this function. You can use the same function
> inside the debugfs core like this, but never export such a complex set
> of parameters to actual users, that's just painful.

Thanks for your review, updated in v2.

Regards,
Li

\
 
 \ /
  Last update: 2023-03-26 23:36    [W:0.020 / U:1.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site