Messages in this thread | ![/](/images/icornerl.gif) | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH V1] lib/scatterlist: Fix to calculate the last_pg properly | Date | Wed, 11 Jan 2023 10:22:24 +0000 |
| |
On 1/11/23 02:10, Yishai Hadas wrote: > The last_pg is wrong, it is actually the first page of the last > scatterlist element. To get the last page of the last scatterlist > element we have to add prv->length. So it is checking mergability > against the wrong page, Further, a SG element is not guaranteed to end > on a page boundary, so we have to check the sub page location also for > merge eligibility. > > Fix the above by checking physical contiguity based on PFNs, compute the > actual last page and then call pages_are_mergable(). > > Fixes: 1567b49d1a40 ("lib/scatterlist: add check when merging zone device pages") > Reported-by: Jason Gunthorpe <jgg@nvidia.com> > Signed-off-by: Yishai Hadas <yishaih@nvidia.com> > ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
| ![\](/images/icornerr.gif) |