Messages in this thread | | | From | JeeHeng Sia <> | Subject | RE: [PATCH v2 3/3] RISC-V: Add arch functions to support hibernation/suspend-to-disk | Date | Wed, 11 Jan 2023 05:05:16 +0000 |
| |
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Wednesday, 11 January, 2023 4:22 AM > To: JeeHeng Sia <jeeheng.sia@starfivetech.com> > Cc: Andrew Jones <ajones@ventanamicro.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; linux- > riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com>; Mason Huo > <mason.huo@starfivetech.com> > Subject: Re: [PATCH v2 3/3] RISC-V: Add arch functions to support hibernation/suspend-to-disk > > Hey JeeHeng, > > On Tue, Jan 10, 2023 at 08:37:01AM +0000, JeeHeng Sia wrote: > > > From: Andrew Jones <ajones@ventanamicro.com> > > > On Mon, Jan 09, 2023 at 02:24:07PM +0800, Sia Jee Heng wrote: > > > > > +/* Helper parameters that help us to restore the image. > > > > > > Separate line for /* > > ok > > I'm not sure why this one struct has an actual description that > resembles kerneldoc, when nothing else does - but why not make it > actually kerneldoc, as you're almost there as things stand: > https://docs.kernel.org/doc-guide/kernel-doc.html#structure-union-and-enumeration-documentation Thanks. This is a good info, will work on it. > > > > > + * @hartid: To make sure same boot_cpu executing the hibernate/restore > > > code. > > > > + * @saved_satp: Original page table used by the hibernated image. > > > > + * @restore_cpu_addr: The kernel's image address to restore the CPU > > > context. > > ^^ also your mail client is doing some really odd things wrapping wise. Oops. Hope I have fixed it in this round.. > > > > > +static unsigned long temp_pgtable_map_pmd(pmd_t *pmdp, unsigned > > > long vaddr, pgprot_t prot) > > > > +{ > > > > + uintptr_t pmd_idx = pmd_index(vaddr); > > > > + pte_t *ptep; > > > > + > > > > + if (pmd_none(pmdp[pmd_idx])) { > > > > + ptep = (pte_t *) get_safe_page(GFP_ATOMIC); > > > > > > No space between cast and function. Same comment for following functions. > > > I thought checkpatch complained about that. > > Ok. But it is weird that checkpatch doesn't report the issue. > > It does: ok, will double check again. > 20:08:17 conor /stuff/linux$ ./scripts/checkpatch.pl --strict --terse -g HEAD~3..HEAD > 7481f133eb0310496742c27d15a20fdd2c499d29:97: CHECK: Alignment should match open parenthesis > [...] > 7481f133eb0310496742c27d15a20fdd2c499d29:370: CHECK: No space is necessary after a cast > [...] > 7481f133eb0310496742c27d15a20fdd2c499d29:460: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:467: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:475: CHECK: Blank lines aren't necessary after an open brace '{' > 7481f133eb0310496742c27d15a20fdd2c499d29:480: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:487: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:499: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:506: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:518: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:525: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:577: CHECK: No space is necessary after a cast > 7481f133eb0310496742c27d15a20fdd2c499d29:591: CHECK: Alignment should match open parenthesis > 7481f133eb0310496742c27d15a20fdd2c499d29:596: CHECK: Alignment should match open parenthesis > total: 0 errors, 1 warnings, 21 checks, 545 lines checked > > The patchwork automation seems to have ignored this patchset for some > reason. It was stuck on a patchset for some reason and this one may > have got skipped when I tried to sort that out. > Ordinarily, you'd see it complaining about these sorts of things. > > Thanks, > Conor.
| |