Messages in this thread | ![/](/images/icornerl.gif) | | From | Bjorn Andersson <> | Subject | Re: [PATCH] soc: qcom: ramp_controller: Make things static | Date | Tue, 10 Jan 2023 23:09:37 -0600 |
| |
On Mon, 9 Jan 2023 20:20:04 -0800, Bjorn Andersson wrote: > The five msm8976_cfg_* objects ought to be static, as reported by LKP > and sparse, fix this. > > drivers/soc/qcom/ramp_controller.c:235:27: sparse: sparse: symbol 'msm8976_cfg_dfs_sid' was not declared. Should it be static? > drivers/soc/qcom/ramp_controller.c:246:27: sparse: sparse: symbol 'msm8976_cfg_link_sid' was not declared. Should it be static? > drivers/soc/qcom/ramp_controller.c:250:27: sparse: sparse: symbol 'msm8976_cfg_lmh_sid' was not declared. Should it be static? > drivers/soc/qcom/ramp_controller.c:256:27: sparse: sparse: symbol 'msm8976_cfg_ramp_en' was not declared. Should it be static? > drivers/soc/qcom/ramp_controller.c:262:27: sparse: sparse: symbol 'msm8976_cfg_ramp_dis' was not declared. Should it be static? > > [...]
Applied, thanks!
[1/1] soc: qcom: ramp_controller: Make things static commit: d45fb976f46600554e2db02ce5d16d1dff84d106
Best regards, -- Bjorn Andersson <andersson@kernel.org>
| ![\](/images/icornerr.gif) |