Messages in this thread | ![/](/images/icornerl.gif) | | From | Heiko Stübner <> | Subject | Re: [PATCHv4 linux-next 3/4] Rockchip RV1126 has GMAC 10/100/1000M ethernet controller | Date | Wed, 11 Jan 2023 11:43:42 +0100 |
| |
Am Mittwoch, 11. Januar 2023, 11:31:40 CET schrieb Anand Moon: > Hi Heiko, > > Thanks for your review comments. > > On Wed, 11 Jan 2023 at 15:41, Heiko Stübner <heiko@sntech.de> wrote: > > > > Hi, > > > > Am Mittwoch, 11. Januar 2023, 07:48:38 CET schrieb Anand Moon: > > > Add Ethernet GMAC node for RV1126 SoC. > > > > > > Signed-off-by: Anand Moon <anand@edgeble.ai> > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > > > patches 2-4 have this Signed-off-by from Jagan again where he is not > > not the author but also not the sender. > > We both work to fix this patch hence Jagan's SoB was added.
ok, then I think the correct way to express that would be:
Co-Developed-by: Jagan Teki <jagan@edgeble.ai> Signed-off-by: Jagan Teki <jagan@edgeble.ai> Signed-off-by: Anand Moon <anand@edgeble.ai>
> > > > Also this patch here, needs a fixed subject with the correct prefixes. > > > Ok, will fix this in the next version. > > > > Heiko > > > > > --- > > > v4: sort the node as reg adds. update the commit message. > > > v3: drop the gmac_clkin_m0 & gmac_clkin_m1 fix clock node which are not > > > used, Add SoB of Jagan Teki. > > > v2: drop SoB of Jagan Teki. > > Thanks > -Anand >
| ![\](/images/icornerr.gif) |