Messages in this thread | | | Date | Wed, 11 Jan 2023 14:58:23 -0700 | Subject | Re: [PATCH] caif: don't assume iov_iter type | From | Jens Axboe <> |
| |
On 1/11/23 11:42 AM, Keith Busch wrote: > From: Keith Busch <kbusch@kernel.org> > > The details of the iov_iter types are appropriately abstracted, so > there's no need to check for specific type fields. Just let the > abstractions handle it. > > This is preparing for io_uring/net's io_send to utilize the more > efficient ITER_UBUF.
Looks good to me - the correct return here would be -EFAULT as well, not -EINVAL. Which is what will happen once memcpy_from_msg() is called anyway.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
-- Jens Axboe
| |