Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 11 Jan 2023 13:37:30 -0800 | Subject | Re: [PATCH 1/2] soc: qcom: socinfo: Change socinfo variable name and scope | From | Trilok Soni <> |
| |
On 1/11/2023 12:21 AM, Naman Jain wrote: > Change socinfo structure variable scope from function to file > to make it easy to support custom attributes for sysfs. Also, > change variable name to make it more descriptive.
Did you mean debugfs?
Can you one example of custom attribute in the commit text so that we understand the motivation better?
> > Signed-off-by: Naman Jain <quic_namajain@quicinc.com> > --- > drivers/soc/qcom/socinfo.c | 80 ++++++++++++++++++++------------------ > 1 file changed, 42 insertions(+), 38 deletions(-) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > index 10efdbcfdf05..251c0fd94962 100644 > --- a/drivers/soc/qcom/socinfo.c > +++ b/drivers/soc/qcom/socinfo.c > @@ -175,6 +175,7 @@ struct socinfo { > __le32 npartnamemap_offset; > __le32 nnum_partname_mapping; > }; > +static struct socinfo *soc_info;
Is there any better way to do it? Should not asume the just one object and dynamically allocate it? Let's wait for Bjorn to check as well.
---Trilok Soni
| ![\](/images/icornerr.gif) |