Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 10 Jan 2023 11:03:08 -0600 | Subject | Re: [PATCH v2] crypto: ccp: initialize error | From | Tom Lendacky <> |
| |
On 1/10/23 10:53, Tom Rix wrote: > clang static analysis reports this problem
s/clang/Clang/
> drivers/crypto/ccp/sev-dev.c:1347:3: warning: 3rd function call > argument is an uninitialized value [core.CallAndMessage] > dev_err(sev->dev, "SEV: failed to INIT error %#x, rc %d\n", > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > __sev_platform_init_locked() can return without setting the > error parameter, causing the dev_err() to report a garbage > value. > > Fixes: 200664d5237f ("crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support") > Signed-off-by: Tom Rix <trix@redhat.com>
The subject is pretty generic and confusing. A better subject would be:
crypto: ccp: Fix use of uninitialized variable
or something along that line.
Thanks, Tom
> --- > v2 : cleanup commit log > --- > drivers/crypto/ccp/sev-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c > index 56998bc579d6..643cccc06a0b 100644 > --- a/drivers/crypto/ccp/sev-dev.c > +++ b/drivers/crypto/ccp/sev-dev.c > @@ -1307,7 +1307,7 @@ EXPORT_SYMBOL_GPL(sev_issue_cmd_external_user); > void sev_pci_init(void) > { > struct sev_device *sev = psp_master->sev_data; > - int error, rc; > + int error = 0, rc; > > if (!sev) > return;
| ![\](/images/icornerr.gif) |