Messages in this thread Patch in this message | | | Date | Tue, 10 Jan 2023 18:01:00 +0100 | Subject | Re: [PATCH] pr_info("I changed uvcvideo driver in the Linux Kernel\n"); | From | Andrzej Pietrasiewicz <> |
| |
Hi,
W dniu 10.01.2023 o 00:39, Xiaxi Shen pisze: > Hi Andrzej, > > Thanks for your advice. > It is my first time to send a patch, I will definitely check my explanation > according to relevant guidelines before my future submission
I recommend reading:
Documentation/process/*.
Regards,
Andrzej
> > Yours sincerely, > Xiaxi Shen > > Andrzej Pietrasiewicz <andrzej.p@collabora.com <mailto:andrzej.p@collabora.com>> > 于2023年1月9日周一 08:14写道: > > Hello XiaxiShen, > > From Documentation/process/researcher-guidelines.rst: > > "The Linux kernel community expects that everyone interacting with the > project is participating in good faith to make Linux better." > > Please explain how your patch will make Linux better. "I added a pr_info() > which emits information unrelated to work of the driver" is not enough of an > explanation. > > Failing to do so and to adhere to the expectation quoted above > you risk any patches to the kernel submitted by you being disregarded. > > Andrzej > > W dniu 30.12.2022 o 04:46, XiaxiShen pisze: > > Signed-off-by: XiaxiShen <shenxiaxi26@gmail.com > <mailto:shenxiaxi26@gmail.com>> > > --- > > drivers/media/usb/uvc/uvc_driver.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c > b/drivers/media/usb/uvc/uvc_driver.c > > index e4bcb5011360..60778a5a2b4e 100644 > > --- a/drivers/media/usb/uvc/uvc_driver.c > > +++ b/drivers/media/usb/uvc/uvc_driver.c > > @@ -2082,6 +2082,8 @@ static int uvc_probe(struct usb_interface *intf, > > (const struct uvc_device_info *)id->driver_info; > > int function; > > int ret; > > + pr_info("I changed uvcvideo driver in the Linux Kernel\n"); > > + > > > > /* Allocate memory for the device and initialize it. */ > > dev = kzalloc(sizeof(*dev), GFP_KERNEL); >
| |