lkml.org 
[lkml]   [2023]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [net PATCH] octeontx2-pf: Fix resource leakage in VF driver unbind
    On Mon, Jan 09, 2023 at 11:43:25AM +0530, Hariprasad Kelam wrote:
    > resources allocated like mcam entries to support the Ntuple feature
    > and hash tables for the tc feature are not getting freed in driver
    > unbind. This patch fixes the issue.

    It is not clear where in otx2vf_probe() these resource are allocated.
    Please add the stack trace to the commit message.

    Thanks

    >
    > Fixes: 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count")
    > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
    > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
    > ---
    > drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
    > index 86653bb8e403..7f8ffbf79cf7 100644
    > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
    > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
    > @@ -758,6 +758,8 @@ static void otx2vf_remove(struct pci_dev *pdev)
    > if (vf->otx2_wq)
    > destroy_workqueue(vf->otx2_wq);
    > otx2_ptp_destroy(vf);
    > + otx2_mcam_flow_del(vf);
    > + otx2_shutdown_tc(vf);
    > otx2vf_disable_mbox_intr(vf);
    > otx2_detach_resources(&vf->mbox);
    > if (test_bit(CN10K_LMTST, &vf->hw.cap_flag))
    > --
    > 2.17.1
    >

    \
     
     \ /
      Last update: 2023-03-26 23:34    [W:7.988 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site