Messages in this thread | | | Subject | Re: [PATCH net] net/x25: fix call timeouts in blocking connects | From | patchwork-bot+netdevbpf@kernel ... | Date | Tue, 09 Aug 2022 04:00:14 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>:
On Fri, 5 Aug 2022 08:18:10 +0200 you wrote: > When a userspace application starts a blocking connect(), a CALL REQUEST > is sent, the t21 timer is started and the connect is waiting in > x25_wait_for_connection_establishment(). If then for some reason the t21 > timer expires before any reaction on the assigned logical channel (e.g. > CALL ACCEPT, CLEAR REQUEST), there is sent a CLEAR REQUEST and timer > t23 is started waiting for a CLEAR confirmation. If we now receive a > CLEAR CONFIRMATION from the peer, x25_disconnect() is called in > x25_state2_machine() with reason "0", which means "normal" call > clearing. This is ok, but the parameter "reason" is used as sk->sk_err > in x25_disconnect() and sock_error(sk) is evaluated in > x25_wait_for_connection_establishment() to check if the call is still > pending. As "0" is not rated as an error, the connect will stuck here > forever. > > [...]
Here is the summary with links: - [net] net/x25: fix call timeouts in blocking connects https://git.kernel.org/netdev/net/c/944e594cfa84
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |