lkml.org 
[lkml]   [2022]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH 2/6] dt-bindings: crypto: add binding for eip29t2 public key accelerator (PKA)
From
On 08/08/2022 22:12, Daniel Parks wrote:
> The PKA is a mmio-only asymmetric crypto accelerator available on
> certain K3 devices.
>
> Signed-off-by: Daniel Parks <danielrparks@ti.com>
> ---
> .../inside-secure,safexcel-eip29t2.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml
> new file mode 100644
> index 000000000000..b1e195a108cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/inside-secure,safexcel-eip29t2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: K3 SoC SA2UL PKA crypto module

If this is the child mentioned in patch #1, then this should be first
patch and your next one should reference it.

> +
> +maintainers:
> + - Daniel Parks <danielrparks@ti.com>
> +
> +description: |
> + Asymmetric crypto accelerator
> +
> +properties:
> + compatible:
> + const: inside-secure,safexcel-eip29t2
> +
> + reg:
> + items:
> + - description: control registers
> + - description: mapped memory
> +
> + interrupts:
> + items:
> + - description: PKA interrupt

This could be "maxItems:1" because your description actually does not
bring anything new, but current choice is also OK.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-08-09 07:48    [W:0.104 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site