lkml.org 
[lkml]   [2022]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] locking: Add __lockfunc to slow path functions
On Tue, Aug 9, 2022 at 4:09 PM Waiman Long <longman@redhat.com> wrote:
>
> On 8/9/22 17:13, Namhyung Kim wrote:
> > --- a/arch/x86/include/asm/qspinlock_paravirt.h
> > +++ b/arch/x86/include/asm/qspinlock_paravirt.h
> > @@ -36,7 +36,7 @@ PV_CALLEE_SAVE_REGS_THUNK(__pv_queued_spin_unlock_slowpath);
> > * rsi = lockval (second argument)
> > * rdx = internal variable (set to 0)
> > */
> > -asm (".pushsection .text;"
> > +asm (".pushsection .spinlock.text;"
> > ".globl " PV_UNLOCK ";"
> > ".type " PV_UNLOCK ", @function;"
> > ".align 4,0x90;"
> >
> That is what I meant. However, you should also a comment saying that the
> use of .spinlock.text section is equivalent to the use of __lockfunc on
> an equivalent C function to make it clear. Also add the __lockfunc to
> the pseudo code in the comment section.

Thanks, will add!
Namhyung

\
 
 \ /
  Last update: 2022-08-10 01:37    [W:0.043 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site