Messages in this thread Patch in this message | | | From | Prashant Malani <> | Subject | [PATCH v6 6/7] platform/chrome: cros_ec_typec: Cleanup switch handle return paths | Date | Tue, 16 Aug 2022 21:48:34 +0000 |
| |
Some of the return paths for the cros_typec_get_switch_handles() aren't necessary. Clean up the return paths to only undo the handle get's which succeeded.
Signed-off-by: Prashant Malani <pmalani@chromium.org> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org> ---
Changes since v5: - Picked up Reviewed-by tags.
Changes since v4: - No changes.
Changes since v3: - No changes.
Changes since v2: - No changes.
Changes since v1: - No changes.
drivers/platform/chrome/cros_ec_typec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index de6ee0f926a6..ee54add992db 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -158,12 +158,10 @@ static int cros_typec_get_switch_handles(struct cros_typec_port *port, return 0; role_sw_err: - usb_role_switch_put(port->role_sw); -ori_sw_err: typec_switch_put(port->ori_sw); -mux_err: +ori_sw_err: typec_mux_put(port->mux); - +mux_err: return -ENODEV; } -- 2.37.1.595.g718a3a8f04-goog
| |