lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v10 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size
    On Thu, Aug 11, 2022 at 04:30:35PM +0200, Pankaj Raghav wrote:
    > @@ -101,13 +101,6 @@ int nvme_update_zone_info(struct nvme_ns *ns, unsigned lbaf)
    > }
    >
    > ns->zsze = nvme_lba_to_sect(ns, le64_to_cpu(id->lbafe[lbaf].zsze));
    > - if (!is_power_of_2(ns->zsze)) {
    > - dev_warn(ns->ctrl->device,
    > - "invalid zone size:%llu for namespace:%u\n",
    > - ns->zsze, ns->head->ns_id);
    > - status = -ENODEV;
    > - goto free_data;
    > - }

    We used to bail out early if the format wasn't supported, which wouldn't create
    the namespace.

    Now you are relying on blk_revalidate_disk_zones() to report an error for
    invalid format, but the handling for an error there is different: the namespace
    still gets created. I'm not sure if that's a problem, but it's different.

    \
     
     \ /
      Last update: 2022-08-16 23:17    [W:2.850 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site