lkml.org 
[lkml]   [2022]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0841/1157] mmc: core: quirks: Add of_node_put() when breaking out of loop
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 883c1d6fa4368a63cae2d6ae2d9c91141c60e233 ]

    In mmc_fixup_of_compatible_match(), we should call of_node_put()
    when breaking out of for_each_child_of_node() which will increase
    and decrease the refcount during one iteration.

    Fixes: b360b1102670 ("mmc: core: allow to match the device tree to apply quirks")
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220719091051.1210806-1-windhl@126.com
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/core/quirks.h | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
    index f879dc63d936..be4393988086 100644
    --- a/drivers/mmc/core/quirks.h
    +++ b/drivers/mmc/core/quirks.h
    @@ -163,8 +163,10 @@ static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card,
    struct device_node *np;

    for_each_child_of_node(mmc_dev(card->host)->of_node, np) {
    - if (of_device_is_compatible(np, compatible))
    + if (of_device_is_compatible(np, compatible)) {
    + of_node_put(np);
    return true;
    + }
    }

    return false;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 06:47    [W:8.525 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site