Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH V6 9/9] virtio: use WARN_ON() to warning illegal status value | Date | Fri, 27 May 2022 15:49:37 +0800 | From | Xuan Zhuo <> |
| |
On Fri, 27 May 2022 14:01:20 +0800, Jason Wang <jasowang@redhat.com> wrote: > We used to use BUG_ON() in virtio_device_ready() to detect illegal > status value, this seems sub-optimal since the value is under the > control of the device. Switch to use WARN_ON() instead. > > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: "Paul E. McKenney" <paulmck@kernel.org> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Halil Pasic <pasic@linux.ibm.com> > Cc: Cornelia Huck <cohuck@redhat.com> > Cc: Vineeth Vijayan <vneethv@linux.ibm.com> > Cc: Peter Oberparleiter <oberpar@linux.ibm.com> > Cc: linux-s390@vger.kernel.org > Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> --- > include/linux/virtio_config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > index d4edfd7d91bb..9a36051ceb76 100644 > --- a/include/linux/virtio_config.h > +++ b/include/linux/virtio_config.h > @@ -255,7 +255,7 @@ void virtio_device_ready(struct virtio_device *dev) > { > unsigned status = dev->config->get_status(dev); > > - BUG_ON(status & VIRTIO_CONFIG_S_DRIVER_OK); > + WARN_ON(status & VIRTIO_CONFIG_S_DRIVER_OK); > > /* > * The virtio_synchronize_cbs() makes sure vring_interrupt() > -- > 2.25.1 >
| ![\](/images/icornerr.gif) |