lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7 03/10] dt-bindings: arm: Adds CoreSight TPDM hardware definitions
    From
    Cc: Rob Herring

    Hi

    Please Cc Rob for any new DT/Yaml additions. I have done so now.




    On 09/05/2022 14:39, Mao Jinlong wrote:
    > Adds new coresight-tpdm.yaml file describing the bindings required
    > to define tpdm in the device trees.
    >
    > Reviewed-by: Mike Leach <mike.leach@linaro.org>
    > Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
    > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>

    Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>

    > ---
    > .../bindings/arm/coresight-tpdm.yaml | 99 +++++++++++++++++++
    > .../devicetree/bindings/arm/coresight.txt | 7 ++
    > MAINTAINERS | 1 +
    > 3 files changed, 107 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/arm/coresight-tpdm.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml
    > new file mode 100644
    > index 000000000000..451342d3d8b7
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/arm/coresight-tpdm.yaml
    > @@ -0,0 +1,99 @@
    > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
    > +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/arm/coresight-tpdm.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Trace, Profiling and Diagnostics Monitor - TPDM
    > +
    > +description: |
    > + The TPDM or Monitor serves as data collection component for various dataset
    > + types specified in the QPMDA spec. It covers Implementation defined ((ImplDef),
    > + Basic Counts (BC), Tenure Counts (TC), Continuous Multi-Bit (CMB), and Discrete
    > + Single Bit (DSB). It performs data collection in the data producing clock
    > + domain and transfers it to the data collection time domain, generally ATB
    > + clock domain.
    > +
    > + The primary use case of the TPDM is to collect data from different data
    > + sources and send it to a TPDA for packetization, timestamping, and funneling.
    > +
    > +maintainers:
    > + - Mao Jinlong <quic_jinlmao@quicinc.com>
    > + - Tao Zhang <quic_taozha@quicinc.com>
    > +
    > +properties:
    > + $nodename:
    > + pattern: "^tpdm(@[0-9a-f]+)$"
    > + compatible:
    > + items:
    > + - const: qcom,coresight-tpdm
    > + - const: arm,primecell
    > +
    > + reg:
    > + maxItems: 1
    > +
    > + clocks:
    > + maxItems: 1
    > +
    > + clock-names:
    > + items:
    > + - const: apb_pclk
    > +
    > + out-ports:
    > + description: |
    > + Output connections from the TPDM to coresight funnle/tpda.
    > + $ref: /schemas/graph.yaml#/properties/ports
    > + properties:
    > + port:
    > + description: Output connection from the TPDM to coresight
    > + funnel/tpda.
    > + $ref: /schemas/graph.yaml#/properties/port
    > +
    > +required:
    > + - compatible
    > + - reg
    > + - clocks
    > + - clock-names
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > + # minimum TPDM definition. TPDM connect to coresight funnel.
    > + - |
    > + tpdm@6980000 {
    > + compatible = "qcom,coresight-tpdm", "arm,primecell";
    > + reg = <0x6980000 0x1000>;
    > +
    > + clocks = <&aoss_qmp>;
    > + clock-names = "apb_pclk";
    > +
    > + out-ports {
    > + port {
    > + tpdm_turing_out_funnel_turing: endpoint {
    > + remote-endpoint =
    > + <&funnel_turing_in_tpdm_turing>;
    > + };
    > + };
    > + };
    > + };
    > + # minimum TPDM definition. TPDM connect to coresight TPDA.
    > + - |
    > + tpdm@684c000 {
    > + compatible = "qcom,coresight-tpdm", "arm,primecell";
    > + reg = <0x684c000 0x1000>;
    > +
    > + clocks = <&aoss_qmp>;
    > + clock-names = "apb_pclk";
    > +
    > + out-ports {
    > + port {
    > + tpdm_prng_out_tpda_qdss: endpoint {
    > + remote-endpoint =
    > + <&tpda_qdss_in_tpdm_prng>;
    > + };
    > + };
    > + };
    > + };
    > +
    > +...
    > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
    > index c68d93a35b6c..f7ce8af48574 100644
    > --- a/Documentation/devicetree/bindings/arm/coresight.txt
    > +++ b/Documentation/devicetree/bindings/arm/coresight.txt
    > @@ -52,6 +52,10 @@ its hardware characteristcs.
    > "arm,coresight-cti", "arm,primecell";
    > See coresight-cti.yaml for full CTI definitions.
    >
    > + - Trace, Profiling and Diagnostics Monitor (TPDM):
    > + "qcom,coresight-tpdm", "arm,primecell";
    > + See coresight-tpdm.yaml for full TPDM definitions.
    > +
    > * reg: physical base address and length of the register
    > set(s) of the component.
    >
    > @@ -82,6 +86,9 @@ its hardware characteristcs.
    > * Required properties for Coresight Cross Trigger Interface (CTI)
    > See coresight-cti.yaml for full CTI definitions.
    >
    > +* Required properties for Trace, Profiling and Diagnostics Monitor (TPDM)
    > + See coresight-tpdm.yaml for full TPDM definitions.
    > +
    > * Required properties for devices that don't show up on the AMBA bus, such as
    > non-configurable replicators and non-configurable funnels:
    >
    > diff --git a/MAINTAINERS b/MAINTAINERS
    > index edc96cdb85e8..28d32b3f3f5c 100644
    > --- a/MAINTAINERS
    > +++ b/MAINTAINERS
    > @@ -1978,6 +1978,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git
    > F: Documentation/ABI/testing/sysfs-bus-coresight-devices-*
    > F: Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
    > F: Documentation/devicetree/bindings/arm/coresight-cti.yaml
    > +F: Documentation/devicetree/bindings/arm/coresight-tpdm.yaml
    > F: Documentation/devicetree/bindings/arm/coresight.txt
    > F: Documentation/devicetree/bindings/arm/ete.yaml
    > F: Documentation/devicetree/bindings/arm/trbe.yaml

    \
     
     \ /
      Last update: 2022-05-23 11:07    [W:8.838 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site