lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] LoongArch: take size of pointed value, not pointer
Hi, Haowen,

On Tue, May 24, 2022 at 10:52 AM Haowen Bai <baihaowen@meizu.com> wrote:
>
> Sizeof a pointer-typed expression returns the size of the pointer, not
> that of the pointed data.
Your patch is correct, but the original patch hasn't been upstream, I don't
know how to handle it.

>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> arch/loongarch/kernel/efi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/efi.c b/arch/loongarch/kernel/efi.c
> index f9fdeb1ae358..f0e5d0feffc2 100644
> --- a/arch/loongarch/kernel/efi.c
> +++ b/arch/loongarch/kernel/efi.c
> @@ -180,7 +180,7 @@ void __init efi_init(void)
> if (!efi_system_table)
> return;
>
> - efi_systab = (efi_system_table_t *)early_memremap_ro(efi_system_table, sizeof(efi_systab));
> + efi_systab = (efi_system_table_t *)early_memremap_ro(efi_system_table, sizeof(*efi_systab));
> if (!efi_systab) {
> pr_err("Can't find EFI system table.\n");
> return;
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2022-05-24 05:07    [W:0.105 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site