Messages in this thread | | | Date | Mon, 23 May 2022 17:10:07 -0700 | Subject | Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style | From | Roopa Prabhu <> |
| |
On 5/20/22 17:40, Jakub Kicinski wrote: > On Thu, 19 May 2022 22:06:53 -0700 Roopa Prabhu wrote: >>> @@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan, >>> if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] || >>> tb[NDA_PORT])) { >>> NL_SET_ERR_MSG(extack, >>> - "DST, VNI, ifindex and port are mutually exclusive with NH_ID"); >>> + "DST, VNI, ifindex and port are mutually exclusive with NH_ID"); >> it looks still off by a space. >> >>> return -EINVAL; >>> } >> >> this closing brace should line up with the if > Let me just fix this myself when applying... There were 3 separate > postings of v2, and they weren't even identical :(
thanks Jakub,
Alaa, when you accidentally send the same patch multiple times, you can reply on the list and leave a note to the maintainer on which ones to ignore (lets add this to the outreachy kernel patch submission instructions if not already there)
| |