lkml.org 
[lkml]   [2022]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/9] serial: uartline: Fix BRKINT clearing
From
Date


On 5/17/22 7:07 AM, Ilpo Järvinen wrote:
> BRKINT is within c_iflag rather than c_cflag.
>
> Cc: Sean Anderson <sean.anderson@seco.com>
> Fixes: ea017f5853e9 (tty: serial: uartlite: Prevent changing fixed parameters)
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/uartlite.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 007db67292a2..880e2afbb97b 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -321,7 +321,8 @@ static void ulite_set_termios(struct uart_port *port, struct ktermios *termios,
> struct uartlite_data *pdata = port->private_data;
>
> /* Set termios to what the hardware supports */
> - termios->c_cflag &= ~(BRKINT | CSTOPB | PARENB | PARODD | CSIZE);
> + termios->c_iflag &= ~BRKINT;
> + termios->c_cflag &= ~(CSTOPB | PARENB | PARODD | CSIZE);
> termios->c_cflag |= pdata->cflags & (PARENB | PARODD | CSIZE);
> tty_termios_encode_baud_rate(termios, pdata->baud, pdata->baud);
>
>

Reviewed-by: Sean Anderson <sean.anderson@seco.com>

\
 
 \ /
  Last update: 2022-05-17 16:34    [W:0.169 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site