lkml.org 
[lkml]   [2021]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 3/3] nvmem: add ONIE nvmem cells parser
    Date

    Hi Jan,

    Jan Lübbe <jlu@pengutronix.de> writes:

    > Hi,
    >
    > On Tue, 2021-06-08 at 22:03 +0300, Vadym Kochan wrote:
    >
    > ...
    >> + case 0x24: return "mac-address";
    > ...

    This is a base mac,

    >> + case 0x2A: return "num-macs";
    >
    > Is suspect these properties define which range of MACs is assigned to the

    Yes

    > device. How would you use them to assign MAC addresses to multiple interfaces?
    > The nvmem-cells property in the network device's node can only refer to one
    > cell, and not to i.e the cells value + 1.
    >

    Currently in net/ethernet/marvell/prestera/prestera_main.c it is
    incremented and hard-coded by the driver.

    > I think it would be useful to have a way to express this setup for systems with
    > many interfaces, but am unsure of where this should be described. Maybe a "mac-
    > address-offset" property in the generic ethernet controller binding?
    >
    > Regards,
    > Jan

    May be something like eth_address_provider should be introduced in
    net/ethernet/ ?

    This provider can provide something like eth_provider_address_next() which
    will consider "mac-address-num" (or other specific fields).

    \
     
     \ /
      Last update: 2021-09-08 11:58    [W:8.767 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site