Messages in this thread | | | From | Joseph Hwang <> | Date | Sun, 26 Sep 2021 15:14:48 +0800 | Subject | Re: [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report |
| |
Hi Marcel:
I am very sorry that I missed your review comment! I have used net/bluetooth/aosp.c to replace drivers/bluetooth/btandroid.c, and enable the aosp capability by hci_set_aosp_capable() in the drivers.
The new patch subject is
[v4,1/4] Bluetooth: aosp: Support AOSP Bluetooth Quality Report
(https://patchwork.kernel.org/project/bluetooth/patch/20210926150657.v4.1.Iaa4a0269e51d8e8d8784a6ac8e05899b49a1377d@changeid/)
Please take a look.
Thanks and regards, Joseph
On Mon, Sep 13, 2021 at 10:32 PM Marcel Holtmann <marcel@holtmann.org> wrote: > > Hi Joseph, > > > Add the btandroid.c file to support Android BQR commands. > > > > This module may be referenced by btusb, btrtl, and hci_qca when a > > Bluetooth controller supports the Android Bluetooth Quality Report. > > > > Reported-by: kernel test robot <lkp@intel.com> > > > > Reviewed-by: Miao-chen Chou <mcchou@chromium.org> > > Signed-off-by: Joseph Hwang <josephsih@chromium.org> > > --- > > > > Changes in v3: > > - Fix the auto build test ERROR > > "undefined symbol: btandroid_set_quality_report" that occurred > > with some kernel configs. > > - Note that the mgmt-tester "Read Exp Feature - Success" failed. > > But on my test device, the same test passed. Please kindly let me > > know what may be going wrong. These patches do not actually > > modify read/set experimental features. > > - As to CheckPatch failed. No need to modify the MAINTAINERS file. > > Thanks. > > > > Changes in v2: > > - Fix the titles of patches 2/3 and 3/3 and reduce their lengths. > > > > drivers/bluetooth/Kconfig | 5 ++ > > drivers/bluetooth/Makefile | 1 + > > drivers/bluetooth/btandroid.c | 106 ++++++++++++++++++++++++++++++++++ > > drivers/bluetooth/btandroid.h | 10 ++++ > > 4 files changed, 122 insertions(+) > > create mode 100644 drivers/bluetooth/btandroid.c > > create mode 100644 drivers/bluetooth/btandroid.h > > I am confused now. Did you read my review comments? I do _not_ want it this way; so please read my previous response and don’t send the exact same patch again. > > Regards > > Marcel >
--
Joseph Shyh-In Hwang Email: josephsih@google.com
| |