lkml.org 
[lkml]   [2021]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH V4 6/6] riscv: soc: Add Allwinner SoC kconfig option
    On Tue, Sep 14, 2021 at 12:07:08PM +0200, Krzysztof Kozlowski wrote:
    > On Tue, 14 Sept 2021 at 11:31, Arnd Bergmann <arnd@arndb.de> wrote:
    > > Some subsystem maintainers want drivers to be selected by the SoC
    > > option, this is why you need the 'select SIFIVE_PLIC', but usually
    > > the drivers are selectable with a 'depends on ARCH_SUNXI ||
    > > COMPILE_TEST' and enabled in the defconfig.
    >
    > I would say selecting drivers is even more useful for distros and
    > other downstream users. Especially in the ARM world where we have so
    > many different SoCs - how could a distro person know which driver is
    > necessary, important or useful? Having all main SoC drivers enabled
    > when ARCH_SUNXI=y, helps distro a lot.

    Imply, maybe, but select is far too painful for everyone else.

    > > If you want to get fancy, you can use something like:
    > >
    > > config RESET_SUNXI
    > > bool "Allwinner SoCs Reset Driver" if COMPILE_TEST && !ARCH_SUNXI
    > > default ARCH_SUNXI
    > >
    > > This will make an option that
    > > - always enabled when the platform is built-in
    > > - user selectable when compile-testing for any other platform
    > > - always disabled otherwise
    >
    > +1 for this pattern.

    Yeah, or a default

    Maxime
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-09-14 12:14    [W:6.066 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site