Messages in this thread | | | From | Ryan Chen <> | Subject | RE: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula | Date | Wed, 15 Sep 2021 02:52:38 +0000 |
| |
> -----Original Message----- > From: Stephen Boyd <sboyd@kernel.org> > Sent: Wednesday, September 15, 2021 9:17 AM > To: Claudiu.Beznea@microchip.com; Ryan Chen > <ryan_chen@aspeedtech.com>; andrew@aj.id.au; joel@jms.id.au; > linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; > mturquette@baylibre.com > Subject: RE: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula > > Quoting Ryan Chen (2021-09-12 22:31:46) > > > > + if (hwstrap & BIT(10)) > > > > + m = 0x5F; > > > > + else { > > > > + if (hwstrap & BIT(8)) > > > > > > You may write it directly: > > > else if (hwstrap & BIT(8)) > > > > > Hello, > > Like I commit message M = SCU500[10] ? 0x5F : SCU500[8] ? 0xBF : > SCU200[12:0] > > it need keep from register read, if BIT(8)/BIT(10) not 1. > > > > I don't get it. The review comment was that the else { if (...) can be collapsed > into an else if (..) What does commit message have to do with it? Sorry for confuse. Or do you mean like following modification?
if (hwstrap & BIT(10)) m = 0x5F; else if (hwstrap & BIT(8)) m = 0xBF;
| |