Messages in this thread | | | Date | Tue, 14 Sep 2021 18:52:53 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/umip: Add a umip= cmdline switch |
| |
On Mon, Sep 13, 2021 at 02:45:03PM -0700, Ricardo Neri wrote: > Strictly, this hunk does not logically belong to this patch. I guess it > is harmless, though. Admittedly, the new line should have been there > since umip.c was added.
Yeah, I don't like crammed code - that's why I've added it.
> Wouldn't it be better to use parse_option_str() with __setup("umip=", > parse_umip_param)? This would avoid the first two checks.
Sure.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |