lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 051/236] genirq/timings: Fix error return code in irq_timings_test_irqs()
    Date
    From: Zhen Lei <thunder.leizhen@huawei.com>

    [ Upstream commit 290fdc4b7ef14e33d0e30058042b0e9bfd02b89b ]

    Return a negative error code from the error handling case instead of 0, as
    done elsewhere in this function.

    Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/irq/timings.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
    index 6990490fa67b..1f981162648a 100644
    --- a/kernel/irq/timings.c
    +++ b/kernel/irq/timings.c
    @@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)

    __irq_timings_store(irq, irqs, ti->intervals[i]);
    if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
    + ret = -EBADSLT;
    pr_err("Failed to store in the circular buffer\n");
    goto out;
    }
    }

    if (irqs->count != ti->count) {
    + ret = -ERANGE;
    pr_err("Count differs\n");
    goto out;
    }
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 15:37    [W:3.511 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site