lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 010/236] EDAC/mce_amd: Do not load edac_mce_amd module on guests
    Date
    From: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>

    [ Upstream commit 767f4b620edadac579c9b8b6660761d4285fa6f9 ]

    Hypervisors likely do not expose the SMCA feature to the guest and
    loading this module leads to false warnings. This module should not be
    loaded in guests to begin with, but people tend to do so, especially
    when testing kernels in VMs. And then they complain about those false
    warnings.

    Do the practical thing and do not load this module when running as a
    guest to avoid all that complaining.

    [ bp: Rewrite commit message. ]

    Suggested-by: Borislav Petkov <bp@suse.de>
    Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
    Tested-by: Kim Phillips <kim.phillips@amd.com>
    Link: https://lkml.kernel.org/r/20210628172740.245689-1-Smita.KoralahalliChannabasappa@amd.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/edac/mce_amd.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
    index 6c474fbef32a..b6d4ae84a9a5 100644
    --- a/drivers/edac/mce_amd.c
    +++ b/drivers/edac/mce_amd.c
    @@ -1176,6 +1176,9 @@ static int __init mce_amd_init(void)
    c->x86_vendor != X86_VENDOR_HYGON)
    return -ENODEV;

    + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
    + return -ENODEV;
    +
    if (boot_cpu_has(X86_FEATURE_SMCA)) {
    xec_mask = 0x3f;
    goto out;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 15:34    [W:4.194 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site