lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 01/32] staging: wfx: use abbreviated message for "incorrect sequence"
    Date
    From: Jérôme Pouiller <jerome.pouiller@silabs.com>

    The wfx driver checks carefully the coherency of of the DTIM
    notifications. We have noticed several times some small inconsistencies
    from the firmware on these notification. They have never been critical.

    However on the driver side they lead to big fat warnings. Worse, if
    these warning are displayed on UART console, they can be long to display
    (several hundreds of millisecs). Since, this warning is generated from a
    work queue, it can delay all the workqueue users. Especially, it can
    drastically slow down the frame management of the driver and then
    generate errors that are serious this time (eg. an overflow of the
    indication queue of the device).

    Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
    ---
    drivers/staging/wfx/sta.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
    index cb7e8abdf43c..a236e5bb6914 100644
    --- a/drivers/staging/wfx/sta.c
    +++ b/drivers/staging/wfx/sta.c
    @@ -631,8 +631,9 @@ void wfx_suspend_resume_mc(struct wfx_vif *wvif, enum sta_notify_cmd notify_cmd)
    {
    if (notify_cmd != STA_NOTIFY_AWAKE)
    return;
    - WARN(!wfx_tx_queues_has_cab(wvif), "incorrect sequence");
    - WARN(wvif->after_dtim_tx_allowed, "incorrect sequence");
    + if (!wfx_tx_queues_has_cab(wvif) || wvif->after_dtim_tx_allowed)
    + dev_warn(wvif->wdev->dev, "incorrect sequence (%d CAB in queue)",
    + wfx_tx_queues_has_cab(wvif));
    wvif->after_dtim_tx_allowed = true;
    wfx_bh_request_tx(wvif->wdev);
    }
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-09-13 15:02    [W:3.713 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site