Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Mon, 13 Sep 2021 12:52:50 +0800 | Subject | Re: [PATCH v2 1/3] clk: rockchip: rk3399: make CPU clocks critical |
| |
On Thu, Sep 9, 2021 at 3:44 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Wed, Sep 8, 2021 at 11:14 AM Brian Norris <briannorris@chromium.org> wrote: > > > > The CPU clocks don't currently have any owner (e.g., cpufreq-dt doesn't > > enable() them -- and even if it did, it's not early enough compared to > > other consumers -- nor does arch/arm64/kernel/smp.c), and instead are > > simply assumed to be "on" all the time. > > > > They are also parents of a few other clocks which haven't been > > previously exposed for other devices to consume. If we want to expose > > those clocks, then the common clock framework may eventually choose to > > disable their parents (including the CPU PLLs) -- which is no fun for > > anyone. > > > > Thus, mark the CPU clocks as critical, to prevent them from being > > disabled implicitly. > > > > Signed-off-by: Brian Norris <briannorris@chromium.org> > > --- > > > > Changes in v2: > > - New, split from the patch that requires this change > > > > drivers/clk/rockchip/clk-rk3399.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
| |