Messages in this thread | | | Subject | Re: [PATCH] clk: at91: check pmc node status before registering syscore ops | From | Nicolas Ferre <> | Date | Mon, 13 Sep 2021 12:06:38 +0200 |
| |
On 13/09/2021 at 10:26, Clément Léger wrote: > Currently, at91 pmc driver always register the syscore_ops whatever > the status of the pmc node that has been found. When set as secure > and disabled, the pmc should not be accessed or this will generate > abort exceptions. > To avoid this, add a check on node availability before registering > the syscore operations. > > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Yes, indeed, Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks, best regards, Nicolas
> --- > drivers/clk/at91/pmc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c > index 20ee9dccee78..b40035b011d0 100644 > --- a/drivers/clk/at91/pmc.c > +++ b/drivers/clk/at91/pmc.c > @@ -267,6 +267,11 @@ static int __init pmc_register_ops(void) > if (!np) > return -ENODEV; > > + if (!of_device_is_available(np)) { > + of_node_put(np); > + return -ENODEV; > + } > + > pmcreg = device_node_to_regmap(np); > of_node_put(np); > if (IS_ERR(pmcreg)) > -- > 2.33.0 >
-- Nicolas Ferre
| |