lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI
On Mon, Sep 13, 2021 at 07:28:11AM -0600, Jens Axboe wrote:
> This is really the same thing as before, just the names have changed.
> What I suggested was keeping the enum in io_uring, then just adding
>
> enum {
> IO_WQ_BOUND,
> IO_WQ_UNBOUND,
> };
>
> to uapi header. The ACCT stuff is io-wq specific too, that kind of naming
> shouldn't be propagated to userspace.

My apologies, I've overlooked the fact that the proposed names
are different. Updated and resent[1].

[1] https://lore.kernel.org/lkml/20210913154415.GA12890@asgard.redhat.com/

> A BUILD_BUG_ON() could be added for them being different, but honestly
> I don't think that's worth it.

\
 
 \ /
  Last update: 2021-09-13 17:53    [W:0.034 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site