lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 257/334] i2c: mt65xx: fix IRQ check
    Date
    From: Sergey Shtylyov <s.shtylyov@omp.ru>

    [ Upstream commit 58fb7c643d346e2364404554f531cfa6a1a3917c ]

    Iff platform_get_irq() returns 0, the driver's probe() method will return 0
    early (as if the method's call was successful). Let's consider IRQ0 valid
    for simplicity -- devm_request_irq() can always override that decision...

    Fixes: ce38815d39ea ("I2C: mediatek: Add driver for MediaTek I2C controller")
    Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
    Reviewed-by: Qii Wang <qii.wang@mediatek.com>
    Signed-off-by: Wolfram Sang <wsa@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/i2c/busses/i2c-mt65xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
    index 4ca716e09149..477480d1de6b 100644
    --- a/drivers/i2c/busses/i2c-mt65xx.c
    +++ b/drivers/i2c/busses/i2c-mt65xx.c
    @@ -1211,7 +1211,7 @@ static int mtk_i2c_probe(struct platform_device *pdev)
    return PTR_ERR(i2c->pdmabase);

    irq = platform_get_irq(pdev, 0);
    - if (irq <= 0)
    + if (irq < 0)
    return irq;

    init_completion(&i2c->msg_complete);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:45    [W:3.659 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site