lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 237/334] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()
    Date
    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit b74a29fac6de62f39b594e8f545b3a26db7edb5e ]

    Add the missing unlock before return from function g2d_runqueue_worker()
    in the error handling case.

    Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Signed-off-by: Inki Dae <inki.dae@samsung.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
    index cab4d2c370a7..0ed665501ac4 100644
    --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
    +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
    @@ -897,13 +897,14 @@ static void g2d_runqueue_worker(struct work_struct *work)
    ret = pm_runtime_resume_and_get(g2d->dev);
    if (ret < 0) {
    dev_err(g2d->dev, "failed to enable G2D device.\n");
    - return;
    + goto out;
    }

    g2d_dma_start(g2d, g2d->runqueue_node);
    }
    }

    +out:
    mutex_unlock(&g2d->runqueue_mutex);
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:45    [W:7.893 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site