lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 053/334] sched/numa: Fix is_core_idle()
    Date
    From: Mika Penttilä <mika.penttila@gmail.com>

    [ Upstream commit 1c6829cfd3d5124b125e6df41158665aea413b35 ]

    Use the loop variable instead of the function argument to test the
    other SMT siblings for idle.

    Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks")
    Signed-off-by: Mika Penttilä <mika.penttila@gmail.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Acked-by: Mel Gorman <mgorman@techsingularity.net>
    Acked-by: Pankaj Gupta <pankaj.gupta@ionos.com>
    Link: https://lkml.kernel.org/r/20210722063946.28951-1-mika.penttila@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/sched/fair.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index 44c452072a1b..30a6984a58f7 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -1486,7 +1486,7 @@ static inline bool is_core_idle(int cpu)
    if (cpu == sibling)
    continue;

    - if (!idle_cpu(cpu))
    + if (!idle_cpu(sibling))
    return false;
    }
    #endif
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:26    [W:7.573 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site