lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 188/300] devlink: Clear whole devlink_flash_notify struct
    Date
    From: Leon Romanovsky <leonro@nvidia.com>

    [ Upstream commit ed43fbac717882165a2a4bd64f7b1f56f7467bb7 ]

    The { 0 } doesn't clear all fields in the struct, but tells to the
    compiler to set all fields to zero and doesn't touch any sub-fields
    if they exists.

    The {} is an empty initialiser that instructs to fully initialize whole
    struct including sub-fields, which is error-prone for future
    devlink_flash_notify extensions.

    Fixes: 6700acc5f1fe ("devlink: collect flash notify params into a struct")
    Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/core/devlink.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/net/core/devlink.c b/net/core/devlink.c
    index 170e44f5e7df..5d01bebffaca 100644
    --- a/net/core/devlink.c
    +++ b/net/core/devlink.c
    @@ -3607,7 +3607,7 @@ out_free_msg:

    static void devlink_flash_update_begin_notify(struct devlink *devlink)
    {
    - struct devlink_flash_notify params = { 0 };
    + struct devlink_flash_notify params = {};

    __devlink_flash_update_notify(devlink,
    DEVLINK_CMD_FLASH_UPDATE,
    @@ -3616,7 +3616,7 @@ static void devlink_flash_update_begin_notify(struct devlink *devlink)

    static void devlink_flash_update_end_notify(struct devlink *devlink)
    {
    - struct devlink_flash_notify params = { 0 };
    + struct devlink_flash_notify params = {};

    __devlink_flash_update_notify(devlink,
    DEVLINK_CMD_FLASH_UPDATE_END,
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:11    [W:2.411 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site