lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.13 133/300] drm: rcar-du: Dont put reference to drm_device in rcar_du_remove()
    Date
    From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

    [ Upstream commit c29b6b0b126e9ee69a5d6339475e831a149295bd ]

    The reference to the drm_device that was acquired by
    devm_drm_dev_alloc() is released automatically by the devres
    infrastructure. It must not be released manually, as that causes a
    reference underflow..

    Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device")
    Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
    index bfbff90588cb..c22551c2facb 100644
    --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
    +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
    @@ -556,8 +556,6 @@ static int rcar_du_remove(struct platform_device *pdev)

    drm_kms_helper_poll_fini(ddev);

    - drm_dev_put(ddev);
    -
    return 0;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:07    [W:4.071 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site