lkml.org 
[lkml]   [2021]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 177/236] i2c: s3c2410: fix IRQ check
    Date
    From: Sergey Shtylyov <s.shtylyov@omp.ru>

    [ Upstream commit d6840a5e370b7ea4fde16ce2caf431bcc87f9a75 ]

    Iff platform_get_irq() returns 0, the driver's probe() method will return 0
    early (as if the method's call was successful). Let's consider IRQ0 valid
    for simplicity -- devm_request_irq() can always override that decision...

    Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
    Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    Signed-off-by: Wolfram Sang <wsa@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/i2c/busses/i2c-s3c2410.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
    index 40fa9e4af5d1..05831848b7bf 100644
    --- a/drivers/i2c/busses/i2c-s3c2410.c
    +++ b/drivers/i2c/busses/i2c-s3c2410.c
    @@ -1140,7 +1140,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
    */
    if (!(i2c->quirks & QUIRK_POLL)) {
    i2c->irq = ret = platform_get_irq(pdev, 0);
    - if (ret <= 0) {
    + if (ret < 0) {
    dev_err(&pdev->dev, "cannot find IRQ\n");
    clk_unprepare(i2c->clk);
    return ret;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-13 16:07    [W:4.024 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site