Messages in this thread | | | Date | Sat, 11 Sep 2021 22:13:42 +0200 | From | Martin Kaiser <> | Subject | Re: [PATCH 05/12] staging: r8188eu: remove rtw_set_rpwm |
| |
Thus wrote Michael Straube (straube.linux@gmail.com):
> On 9/11/21 16:15, Martin Kaiser wrote: > > After we dropped the call to set HW_VAR_SET_RPWM, the rtw_set_rpwm > > function doesn't do anything useful.
> > Remove the function and the rpwm component of struct pwrctrl_priv, > > which is not used outside of rtw_set_rpwm.
> > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > > --- > > .../realtek/rtl8192cu/include/rtw_pwrctrl.h | 1 - > > drivers/staging/r8188eu/core/rtw_pwrctrl.c | 34 ------------------- > > drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 -- > > 3 files changed, 37 deletions(-)
> > diff --git a/drivers/net/wireless/realtek/rtl8192cu/include/rtw_pwrctrl.h b/drivers/net/wireless/realtek/rtl8192cu/include/rtw_pwrctrl.h > > index a4cb292e1aea..303df55c521a 100644 > > --- a/drivers/net/wireless/realtek/rtl8192cu/include/rtw_pwrctrl.h > > +++ b/drivers/net/wireless/realtek/rtl8192cu/include/rtw_pwrctrl.h > > @@ -309,7 +309,6 @@ extern void cpwm_int_hdl(PADAPTER padapter, struct reportpwrstate_parm *preportp > > #endif
> The patch does not apply to staging-testing.
> Looks to me that the change in
> .../realtek/rtl8192cu/include/rtw_pwrctrl.h
> made it into this patch by accident?
thanks for spotting this, Michael. I'll send a v2 on Monday.
Best regards, Martin
| |