lkml.org 
[lkml]   [2021]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] regulator: core: resolve supply voltage deferral silently
    On Thu, Aug 26, 2021 at 12:40:17PM -0700, Brian Norris wrote:

    > if (current_uV < 0) {
    > - rdev_err(rdev,
    > - "failed to get the current voltage: %pe\n",
    > - ERR_PTR(current_uV));
    > + if (current_uV != -EPROBE_DEFER)
    > + rdev_err(rdev,
    > + "failed to get the current voltage: %pe\n",
    > + ERR_PTR(current_uV));

    This doesn't make sense to me. Why are we getting as far as trying to
    read the voltage if we've been told to defer probe? This suggests that
    we ought to be doing this earlier on. I see that the logic is already
    there to handle a deferral being generated here but it looks off.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-09-01 17:10    [W:7.925 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site